Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Cleanup access to the state in handler messages #89

Closed
5 tasks
vitorenesduarte opened this issue Feb 9, 2021 · 2 comments
Closed
5 tasks

modules: Cleanup access to the state in handler messages #89

vitorenesduarte opened this issue Feb 9, 2021 · 2 comments
Labels
A: good-first-issue Admin: good for newcomers

Comments

@vitorenesduarte
Copy link

Crate

modules

Problem Definition

Currently we have getters for pub fields in the handler messages.

References:

Proposal

Decide on a convention (likely just use pub) and apply it to all handler messages.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Wizdave97
Copy link

@vitorenesduarte @adizere is your suggestion to remove the getters and allow direct access to the properties?

@romac romac added the A: good-first-issue Admin: good for newcomers label Feb 8, 2022
@romac
Copy link
Member

romac commented Feb 8, 2022

@Wizdave97 Yes!

@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants