Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup method parameters in ValidationContext and ExecutionContext #326

Merged
merged 6 commits into from
Jan 6, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 5, 2023

Closes: #319

Description

Also fixes the feature flags typo for val_exec_ctx throughout the codebase.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer requested a review from Farhad-Shabani January 5, 2023 22:07
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 66.31% // Head: 63.21% // Decreases project coverage by -3.10% ⚠️

Coverage data is based on head (323b254) compared to base (968e553).
Patch coverage: 23.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   66.31%   63.21%   -3.11%     
==========================================
  Files         125      126       +1     
  Lines       12922    14121    +1199     
==========================================
+ Hits         8569     8926     +357     
- Misses       4353     5195     +842     
Impacted Files Coverage Δ
...s/ibc/src/clients/ics07_tendermint/client_state.rs 45.69% <0.00%> (-10.34%) ⬇️
crates/ibc/src/core/ics02_client/client_state.rs 75.00% <ø> (ø)
...ibc/src/core/ics02_client/handler/create_client.rs 34.86% <ø> (-51.51%) ⬇️
.../ibc/src/core/ics02_client/handler/misbehaviour.rs 53.77% <ø> (-35.29%) ⬇️
...ibc/src/core/ics02_client/handler/update_client.rs 38.66% <0.00%> (-46.63%) ⬇️
...bc/src/core/ics02_client/handler/upgrade_client.rs 73.36% <ø> (-22.06%) ⬇️
...rc/core/ics03_connection/handler/conn_open_init.rs 55.76% <0.00%> (-44.24%) ⬇️
crates/ibc/src/mock/client_state.rs 76.33% <ø> (-13.83%) ⬇️
crates/ibc/src/core/context.rs 32.72% <20.00%> (-12.28%) ⬇️
crates/ibc/src/mock/context.rs 69.59% <20.00%> (-5.33%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plafer
Copy link
Contributor Author

plafer commented Jan 6, 2023

Good catch 323b254

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@plafer plafer merged commit 75f5040 into main Jan 6, 2023
@plafer plafer deleted the plafer/319-val-exec-hygiene branch January 6, 2023 15:21
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
…t` (#326)

* fix feature-guard typo

* fix compile errors

* fix remaining params

* changelog

* fmt

* forgot some methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants