-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup method parameters in ValidationContext
and ExecutionContext
#326
Conversation
Codecov ReportBase: 66.31% // Head: 63.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 66.31% 63.21% -3.11%
==========================================
Files 125 126 +1
Lines 12922 14121 +1199
==========================================
+ Hits 8569 8926 +357
- Misses 4353 5195 +842
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine 👍
Just please check below lines to make sure they're correct
Good catch 323b254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
…t` (#326) * fix feature-guard typo * fix compile errors * fix remaining params * changelog * fmt * forgot some methods
Closes: #319
Description
Also fixes the feature flags typo for
val_exec_ctx
throughout the codebase.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.