Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with the error variant of new_check_header_and_update method #406

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Fix issue with the error variant of new_check_header_and_update method #406

merged 2 commits into from
Feb 9, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Feb 9, 2023 •
edited
Loading

Closes: #405

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 55.69% // Head: 55.68% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4fb4cc7) compared to base (d11e059).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   55.69%   55.68%   -0.01%     
==========================================
  Files         122      122              
  Lines       17065    17068       +3     
==========================================
  Hits         9505     9505              
- Misses       7560     7563       +3
Impacted Files Coverage Δ
...s/ibc/src/clients/ics07_tendermint/client_state.rs 37.81% <0.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review February 9, 2023 14:47
@Farhad-Shabani Farhad-Shabani requested a review from plafer February 9, 2023 14:47
plafer
plafer approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@plafer plafer merged commit 6f482c1 into main Feb 9, 2023
@plafer plafer deleted the farhad/fix-cons-state-error branch February 9, 2023 16:31
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
Fix issue with the error variant of new_check_header_and_update met…
93945b4 
…hod (#406)

* Return None if ConsensusState not found in new_check_header_and_update_state

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new_check_header_and_update should return None if consensus state not found
2 participants
@Farhad-Shabani @plafer