Refactor Height parsing logic and add test cases #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 73.20% 73.41% +0.20%
==========================================
Files 125 125
Lines 16082 16127 +45
==========================================
+ Hits 11773 11839 +66
+ Misses 4309 4288 -21
☔ View full report in Codecov by Sentry. |
|
Ahh, my bad. Just noticed yours. Would it work with you we move forward with #759? |
|
Or you can also port changes that make sense from there? |
|
no problem |
| @@ -159,6 +159,8 @@ pub enum HeightError { | |||
| }, | |||
| /// attempted to parse an invalid zero height | |||
| ZeroHeight, | |||
| /// the height(`{raw_height}`) is not valid, this format must be used: \[revision_number\]-\[revision_height\] | |||
| InvalidHeight { raw_height: String }, | |||
There was a problem hiding this comment.
Would you rename this to smt like InvalidFormat?
This can a bit confusing given the other InvalidHeight we already have under the ClientError enum
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Refactor Height parsing logic and add test cases * Create 752-fix-752.md * Refactor error message for invalid height format * Update height.rs * Refactored height parsing logic and added tests * Refactor error message for invalid height format * Refactor variable name for consistency in `Height` conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #752
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.