Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Vec<u8> for header attribute instead of Any #766

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix: use Vec<u8> for header attribute instead of Any #766

merged 2 commits into from
Jul 14, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #764

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (9cba2fc) 71.13% compared to head (0ee5417) 71.13%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #766   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         124      124           
  Lines       14779    14779           
=======================================
  Hits        10513    10513           
  Misses       4266     4266
Impacted Files Coverage Δ
crates/ibc/src/core/ics02_client/events.rs 71.42% <80.00%> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 96.15% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review July 14, 2023 19:05
@Farhad-Shabani Farhad-Shabani requested a review from plafer July 14, 2023 19:18
@Farhad-Shabani Farhad-Shabani merged commit c20e491 into main Jul 14, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/use-vec-for-header-attribute branch July 14, 2023 23:30
@Farhad-Shabani Farhad-Shabani mentioned this pull request Aug 7, 2023
Closed
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
fix: use Vec<u8> for header attribute instead of Any (#766)
c1452a7 
* fix(api): use Vec<u8> for HeaderAttribute instead of Any

* misc: add unclog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@plafer plafer Awaiting requested review from plafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICS02] Use Vec<u8> for HeaderAttribute instead of Any
2 participants
@Farhad-Shabani @romac