Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counterparty channel ID to OnChanOpenAck callback #674

Closed
colin-axner opened this issue Mar 7, 2022 · 1 comment
Closed

Add counterparty channel ID to OnChanOpenAck callback #674

colin-axner opened this issue Mar 7, 2022 · 1 comment
Assignees

Comments

@colin-axner
Copy link
Contributor

The spec provides the portID, channelID, and version as the arguments to OnChanOpenAck, but the counterparty channel ID might be set for the first time in this callback (it is empty on ChanOpenInit). The counterparty channel ID should be added to the application callbacks since the channel state is written after the callback is performed. Applications may need access to this information

Ref code in spec:

function handleChanOpenAck(datagram: ChanOpenAck) {
    err = module.onChanOpenAck(
      datagram.portIdentifier,
      datagram.channelIdentifier,
      datagram.version
    )
    abortTransactionUnless(err === nil)
    handler.chanOpenAck(
      datagram.portIdentifier,
      datagram.channelIdentifier,
      datagram.version,
      datagram.proofTry,
      datagram.proofHeight
    )
}

Ref issue on ibc-go #1075

@colin-axner
Copy link
Contributor Author

closed by #676

@tankcdr tankcdr added this to IBC Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in IBC Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant