Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild ics23 proofs with ts-proto for cosmjs compatibility #36

Closed
ethanfrey opened this issue Feb 9, 2021 · 1 comment
Closed

Rebuild ics23 proofs with ts-proto for cosmjs compatibility #36

ethanfrey opened this issue Feb 9, 2021 · 1 comment

Comments

@ethanfrey
Copy link
Contributor

ethanfrey commented Feb 9, 2021

I think it is just about T | null | undefined vs T | undefined.

This is the compile error I got trying it.

Type 'IProofSpec' is not assignable to type '{ leafSpec?: { hash?: HashOp | undefined; prehashKey?: HashOp | undefined; prehashValue?: HashOp | undefined; length?: LengthOp | undefined; prefix?: Uint8Array | undefined; } | undefined; innerSpec?: { ...; } | undefined; maxDepth?: number | undefined; minDepth?: number | undefined; }'.
  Types of property 'leafSpec' are incompatible.
    Type 'ILeafOp | null | undefined' is not assignable to type '{ hash?: HashOp | undefined; prehashKey?: HashOp | undefined; prehashValue?: HashOp | undefined; length?: LengthOp | undefined; prefix?: Uint8Array | undefined; } | undefined'.
      Type 'null' is not assignable to type '{ hash?: HashOp | undefined; prehashKey?: HashOp | undefined; prehashValue?: HashOp | undefined; length?: LengthOp | undefined; prefix?: Uint8Array | undefined; } | undefined'.

176     proofSpecs: [iavlSpec, tendermintSpec],
@crodriguezvega
Copy link

I will close the issue, since we removed the Typescript implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants