Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit VSCMatured packets handled in endblocker #1001

Closed
shaspitz opened this issue Jun 8, 2023 · 0 comments · Fixed by #1004
Closed

Limit VSCMatured packets handled in endblocker #1001

shaspitz opened this issue Jun 8, 2023 · 0 comments · Fixed by #1004
Assignees
Labels
source: audit To indicate an issue found during an audit.

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Jun 8, 2023

Problem

This issue encapsulates what we've defined as "audit issue number 3" internally lol. We need to limit the rate that VSCMatured packets are handled in endblocker.

Closing criteria

Hardcode some number, ex 100 of vsc matured packets st. once you handle that many packets in a single endblocker, handling execution is stopped, and remaining queued packets will be handled on subsequent blocks.

Make sure to include a comment that future improvements to throttling will make the short term solution obsolete!

Problem details

Note this issue will be solved and a part of ICS v2. However, solving #713 will also handle the issue in a future release.

@shaspitz shaspitz added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Jun 8, 2023
@shaspitz shaspitz self-assigned this Jun 8, 2023
@shaspitz shaspitz added source: audit To indicate an issue found during an audit. and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: audit To indicate an issue found during an audit.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant