Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage of ICS misbehaviour E2E tests #1224

Closed
Tracked by #732
sainoe opened this issue Aug 21, 2023 · 0 comments · Fixed by #1225
Closed
Tracked by #732

Improve coverage of ICS misbehaviour E2E tests #1224

sainoe opened this issue Aug 21, 2023 · 0 comments · Fixed by #1225
Assignees
@sainoe
Labels
scope: testing Code review, testing, making sure the code is following the specification.

Comments

@sainoe
Copy link
Contributor

sainoe commented Aug 21, 2023 •
edited
Loading

Problem

Currently, the ICS misbehaviour feature is E2E tested by creating a light client attack that results in the
jailing of the only validator running on the consumer chain. However, the test doesn't verify that the consumer chain is halted as expected.

Closing criteria

Verify that the consumer chain doesn't produce blocks after the jailing occurred in the e2e test.

Problem details
@sainoe sainoe added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Aug 21, 2023
@sainoe sainoe self-assigned this Aug 21, 2023
This was referenced Aug 21, 2023
Merged
Closed
@sainoe sainoe added scope: testing Code review, testing, making sure the code is following the specification. and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Aug 21, 2023
@sainoe sainoe linked a pull request Aug 21, 2023 that will close this issue
feat: improve ICS misbehaviour E2E testing coverage #1225
Merged
20 tasks
@sainoe sainoe changed the title update ICS misbehaviour e2e test Update ICS misbehaviour e2e test Aug 21, 2023
@sainoe sainoe changed the title Update ICS misbehaviour e2e test Update ICS misbehaviour E2E test Aug 22, 2023
@sainoe sainoe changed the title Update ICS misbehaviour E2E test Improve coverage of ICS misbehaviour E2E test Aug 22, 2023
@sainoe sainoe changed the title Improve coverage of ICS misbehaviour E2E test Improve coverage of ICS misbehaviour E2E tests Aug 22, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 22, 2023
@sainoe sainoe moved this from 🩹 Triage to 👀 In review in Cosmos Hub Aug 22, 2023
@sainoe sainoe closed this as completed Aug 23, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve ICS misbehaviour E2E testing coverage cosmos/interchain-security
1 participant
@sainoe