Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSS: Bug when querying has-to-validate #1822

Closed
p-offtermatt opened this issue Apr 26, 2024 · 0 comments · Fixed by #1823
Closed

PSS: Bug when querying has-to-validate #1822

p-offtermatt opened this issue Apr 26, 2024 · 0 comments · Fixed by #1823
Assignees
Labels
source: devnet To indicate an issue surfaced in a devnet. type: bug Issues that need priority attention -- something isn't working

Comments

@p-offtermatt
Copy link
Contributor

Problem

For chains with top-N = 0, the has-to-validate method always includes all validators.

Closing criteria

The has-to-validate method should be fixed to only return validators that have to actually validate.

Problem details

The problem is here:

if topN, found := k.GetTopN(ctx, chainID); found && topN > 0 {

If the chain is not a top N chain, the if is never entered, thus all validators are put into the consumersToValidate list.

@p-offtermatt p-offtermatt added type: bug Issues that need priority attention -- something isn't working source: devnet To indicate an issue surfaced in a devnet. labels Apr 26, 2024
@p-offtermatt p-offtermatt changed the title PSS: Bug when querying PSS: Bug when querying has-to-validate Apr 26, 2024
@p-offtermatt p-offtermatt self-assigned this Apr 26, 2024
@p-offtermatt p-offtermatt linked a pull request May 1, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: devnet To indicate an issue surfaced in a devnet. type: bug Issues that need priority attention -- something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant