Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SPM #753

Closed
Tracked by #852
faddat opened this issue Mar 2, 2023 · 2 comments · Fixed by #812
Closed
Tracked by #852

Remove SPM #753

faddat opened this issue Mar 2, 2023 · 2 comments · Fixed by #812
Labels
type: tech-debt Slows down development in the long run

Comments

@faddat
Copy link
Contributor

faddat commented Mar 2, 2023

This repository was scaffolded with starport, which used to have a module called "spm".

spm is considered harmful because it results in conflicting version imports in many cases. In the case of the ccv repo, that's almost certainly the case. We should remove spm from this repository and replace it with the standard cmd folder layout.
@mpoke mpoke added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Mar 13, 2023
This was referenced Mar 23, 2023
Closed
Merged
Closed
Closed
@faddat
Copy link
Contributor Author

faddat commented Apr 3, 2023

Hey there, bump, this is done

@robert-zaremba
Copy link

Yeah, just learned about SPM. I think the repo was basically copied from a template, rather than using the latest version of ignite CLI.

@mpoke mpoke closed this as completed in #812 Apr 5, 2023
@mpoke mpoke mentioned this issue Apr 14, 2023
Closed
9 tasks
@mpoke mpoke added type: tech-debt Slows down development in the long run and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Apr 14, 2023
@mpoke mpoke added this to Cosmos Hub Apr 14, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Apr 14, 2023
@mpoke mpoke moved this from 🩹 Triage to ✅ Done in Cosmos Hub Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove spm faddat/interchain-security
remove spm 2 faddat/interchain-security
3 participants
@robert-zaremba @faddat @mpoke