Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning if trying to use Ledger in Safari or Firefox #1995

Closed
fedekunze opened this issue Feb 18, 2019 · 9 comments · Fixed by #2537
Closed

Show warning if trying to use Ledger in Safari or Firefox #1995

fedekunze opened this issue Feb 18, 2019 · 9 comments · Fixed by #2537
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed cross-browser 🕸 issues that are a result of having to support multiple browsers good first issue 🙌 ledger 👨‍💻 Issues related to Ledger Nano S

Comments

@fedekunze
Copy link
Contributor

Description:

Safari throws an error if you click on the icon to connect ledger on mobile: https://voyager-staging.interblock.io

unadjustednonraw_mini_2cb2

@fedekunze fedekunze added bug 🐛 issues related to unhandled errors in the code that need to be fixed ledger 👨‍💻 Issues related to Ledger Nano S cross-browser 🕸 issues that are a result of having to support multiple browsers labels Feb 18, 2019
@faboweb
Copy link
Collaborator

faboweb commented Mar 4, 2019

Do we even have ledger on mobile browsers?

@jbibla
Copy link
Collaborator

jbibla commented Mar 4, 2019

let's hide the ledger option on mobile until we support ledger x

@fedekunze
Copy link
Contributor Author

Do we even have ledger on mobile browsers?

The Nano X

let's hide the ledger option on mobile until we support ledger x

Let's not hide it but show a message to use a desktop browser

@faboweb
Copy link
Collaborator

faboweb commented Mar 4, 2019

Let's not hide it but show a message to use a desktop browser

👍

The Nano X

I haven't even seen one yet ^^

@jbibla
Copy link
Collaborator

jbibla commented Mar 18, 2019

  • session modal should say you can only sign in on desktop 😭
  • until we are able to "sign in" without a ledger / password

@faboweb
Copy link
Collaborator

faboweb commented Mar 18, 2019

If only "ledger" is available. If in insecure mode I think people can sign in.

@faboweb
Copy link
Collaborator

faboweb commented Mar 21, 2019

This is happening also on desktop Safari

@faboweb faboweb changed the title Ledger session on mobile throws error on Safari Ledger session throws error on Safari Mar 21, 2019
@faboweb
Copy link
Collaborator

faboweb commented Mar 25, 2019

Apparently Firefox on Mac also doesn't work. (Confirmed)

@faboweb faboweb changed the title Ledger session throws error on Safari Show warning if trying to use Ledger in Safari or Firefox Apr 29, 2019
@migueog
Copy link
Contributor

migueog commented May 3, 2019

@faboweb When I try to reproduce this error using Firefox and Safari, the sign in process doesn't conclude. Is this the error that you're running into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed cross-browser 🕸 issues that are a result of having to support multiple browsers good first issue 🙌 ledger 👨‍💻 Issues related to Ledger Nano S
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants