Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ESC to exit on ActionModal #2189

Closed
faboweb opened this issue Mar 6, 2019 · 1 comment · Fixed by #2527
Closed

Enable ESC to exit on ActionModal #2189

faboweb opened this issue Mar 6, 2019 · 1 comment · Fixed by #2527
Labels
ux-improvement issues that would improve the user experience

Comments

@faboweb
Copy link
Collaborator

faboweb commented Mar 6, 2019

Is your feature request related to a problem? Please describe.

I would like to press escape to close an action modal.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@faboweb faboweb added the ux-improvement issues that would improve the user experience label Mar 6, 2019
@jbibla
Copy link
Collaborator

jbibla commented Mar 6, 2019

AHHHHHHH YESSSSSSSSSSSSSSS

also on Tm-Modal PLEAAZZZEEEE

@colw colw mentioned this issue May 2, 2019
Merged
5 tasks
@faboweb faboweb mentioned this issue May 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ux-improvement issues that would improve the user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colw/2189 Close modal on escape key press luniehq/lunie
2 participants
@faboweb @jbibla