Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid date for staking transactions #2250

Closed
fedekunze opened this issue Mar 13, 2019 · 7 comments · Fixed by #2354
Closed

Invalid date for staking transactions #2250

fedekunze opened this issue Mar 13, 2019 · 7 comments · Fixed by #2354
Assignees
@fedekunze
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@fedekunze
Copy link
Contributor

Describe the bug

Dates from staking transactions are updated somewhere after creation and thus the date becomes invalid.

Added a bug handler in the meantime on #2185.

To Reproduce

  1. Create a staking transaction
  2. Go to Transactions Page (Date is OK)
  3. Go to another page
  4. Go once again to transactions page (Date is broken)

Expected behavior

Tx time shouldn't be updated
@fedekunze fedekunze added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Mar 13, 2019
@fedekunze fedekunze mentioned this issue Mar 13, 2019
Merged
5 tasks
@fedekunze
Copy link
Contributor Author

fedekunze commented Mar 13, 2019 •
edited
Loading

Note: This is not the case for Block page's transactions, only on Transactions and My delegations pages

@jbibla
Copy link
Collaborator

jbibla commented Mar 13, 2019

i thought we addressed this with updating txs individually instead of every block?

@fedekunze fedekunze self-assigned this Mar 18, 2019
@faboweb
Copy link
Collaborator

faboweb commented Mar 20, 2019

Seems fixed on develop

@faboweb faboweb closed this as completed Mar 25, 2019
@fedekunze
Copy link
Contributor Author

No it's not (just reproduced). You need to follow the steps from above

@fedekunze fedekunze reopened this Mar 25, 2019
@faboweb
Copy link
Collaborator

faboweb commented Mar 25, 2019

Tested on staging and I can't reproduce with the steps above.

@fedekunze
Copy link
Contributor Author

I tested it on localhost (develop)

@faboweb
Copy link
Collaborator

faboweb commented Mar 25, 2019

Ok reproduced

@fedekunze fedekunze mentioned this issue Mar 25, 2019
Merged
5 tasks
@faboweb faboweb mentioned this issue Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix staking txs date luniehq/lunie
3 participants
@faboweb @jbibla @fedekunze