Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes action modals overlap each other #2482

Closed
jbibla opened this issue Apr 24, 2019 · 6 comments · Fixed by #2979
Closed

sometimes action modals overlap each other #2482

jbibla opened this issue Apr 24, 2019 · 6 comments · Fixed by #2979
Assignees

Comments

@jbibla
Copy link
Collaborator

jbibla commented Apr 24, 2019

Describe the bug

  • more than 1 action modal is open at a time

To Reproduce

  • if you open a large action modal like send, then open the withdrawal action modal, it will open but behind the send modal and is not visible.

Expected behavior

  • only one action modal should be open at a time. previously opened action modal should close.

Screenshots

Desktop (please complete the following information):

  • OS:
  • Browser:
  • Version:

Smartphone (please complete the following information):

  • Device:
  • OS:
  • Browser
  • Version

Additional context

@colw
Copy link
Contributor

colw commented May 20, 2019

What is the behaviour if someone is halfway through a transaction and attempts to open another action type?

@faboweb
Copy link
Collaborator

faboweb commented May 20, 2019

What is the behaviour if someone is halfway through a transaction and attempts to open another action type?

Good question. Simple solution: When a modal is open, highlight it with a little effect to show the user that he can't open 2.
Long term solution: We would like to minimize the open modal and push it to the left (like on google mail).

@jbibla
Copy link
Collaborator Author

jbibla commented May 21, 2019

we could use an alert for now that says "this transaction is in progress, are you sure you want to close it and open a new one?"

or we could just close the original one as a first fix.

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@jbibla
Copy link
Collaborator Author

jbibla commented Aug 26, 2019

this is still an issue. let's resolve this.

@stale stale bot removed the stale label Aug 26, 2019
@jbibla
Copy link
Collaborator Author

jbibla commented Sep 9, 2019

might be nice to have an alert on close if some details are filled out so users can't accidentally ruin the forms they've filled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants