Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show delegation, undelegation, and redelegation warning messages #2504

Closed
faboweb opened this issue Apr 30, 2019 · 10 comments · Fixed by #2619
Closed

Show delegation, undelegation, and redelegation warning messages #2504

faboweb opened this issue Apr 30, 2019 · 10 comments · Fixed by #2619
Assignees
Labels
ux-improvement issues that would improve the user experience

Comments

@faboweb
Copy link
Collaborator

faboweb commented Apr 30, 2019

Is your feature request related to a problem? Please describe.

As a user it would be good to understand, that I can't use the undelegating tokens for 21 days. The user could loose revenue by that action.
If the user wants to redelegate instead, he needs to do another action that is not clear (set different delegation source). This needs a better UX.

Describe the solution you'd like

Add an undelegation warning
Improve redelegation UX (maybe move into own button)

Describe alternatives you've considered

Additional context

@faboweb faboweb added the ux-improvement issues that would improve the user experience label Apr 30, 2019
@jbibla jbibla changed the title Show undelegation warning Show delegation, undelegation, and redelegation warning messages May 10, 2019
@jbibla
Copy link
Collaborator

jbibla commented May 10, 2019

so, after a long discussion with the cosmos hub team - here is my understanding about redelegation:

  • you can redelegate up to 7 times with the same parties (your address, source validator, destination validator)
  • voting power and rewards / distribution change instantly upon redelegation — but the original delegations are subject to the unbonding period. if the original validator is slashed, your redelegations will also be slashed (unless after the 21 day period)
  • add delegation warning (subject penalities applied to the validator)
  • you cannot redelegate redelegations until after the unbonding period is over. (A -> B is permitted, B -> C is not (until after unbonding period)
  • we should add a warning message and confirmation to undelegation because it is not possible to undo and takes 21 days.

we are going to add some information about this to lunie soon.

Originally posted by @jbibla in #2557 (comment)

@jbibla jbibla self-assigned this May 10, 2019
@colw colw self-assigned this May 15, 2019
@jbibla
Copy link
Collaborator

jbibla commented May 27, 2019

we still need to add a message for delegation and redelegation IMO

@jbibla jbibla reopened this May 27, 2019
@jbibla
Copy link
Collaborator

jbibla commented May 28, 2019

new learning: rewards are instantly auto-withdrawn for redelegations and undelegations.

@cwgoes
Copy link

cwgoes commented Jun 3, 2019

new learning: rewards are instantly auto-withdrawn for redelegations and undelegations.

Isn't it magical? /sarcasm

I expect that's confusing - unfortunately, it's necessitated by the "F1" lazy fee calculation logic.

@jbibla
Copy link
Collaborator

jbibla commented Jun 4, 2019

@cwgoes even though they are instantly withdrawn, are delegators still subject to penalties for 21 days if the original validator is penalized for some reason?

@cwgoes
Copy link

cwgoes commented Jun 4, 2019

@cwgoes even though they are instantly withdrawn, are delegators still subject to penalties for 21 days if the original validator is penalized for some reason?

Yes, though the rewards are not bonded so not subject to any penalties (but the delegation amount is).

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@jbibla
Copy link
Collaborator

jbibla commented Aug 26, 2019

@colw let's make sure these messages are in place for all staking transactions in the action modal.

@stale stale bot removed the stale label Aug 26, 2019
@stale
Copy link

stale bot commented Oct 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 5, 2019
@jbibla
Copy link
Collaborator

jbibla commented Oct 7, 2019

can someone confirm that these messages are in place for all staking transactions in the action modal?

@colw @mariopino

@stale stale bot removed the stale label Oct 7, 2019
@faboweb faboweb closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux-improvement issues that would improve the user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants