Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add row numbers to validator list #2671

Closed
jbibla opened this issue May 31, 2019 · 13 comments · Fixed by #2948
Closed

add row numbers to validator list #2671

jbibla opened this issue May 31, 2019 · 13 comments · Fixed by #2948
Assignees

Comments

@jbibla
Copy link
Collaborator

jbibla commented May 31, 2019

Is your feature request related to a problem? Please describe.

Users expect to see row numbers associated with each validator to help contextualize the validator set. Most validator lists include a row number on the left side to help people understand the rankings.

  • Is this the 8th most powerful validator or the 12th?
  • How many validators are there in total?
  • Which validator is the 100th?

Describe the solution you'd like

Let's add a column on the left hand side of the validator table (or li-validator) and include a row number. This should work on the main validator table but also on the my delegations tab too.

Describe alternatives you've considered

I don't think there are alternatives aside from not displaying the numbers which is unsatisfactory.

@faboweb
Copy link
Collaborator

faboweb commented Jun 3, 2019

Could you give some context here?

@jbibla jbibla changed the title add numbers to validator list add row numbers to validator list Jun 3, 2019
@faboweb
Copy link
Collaborator

faboweb commented Jun 3, 2019

Your sure this is a good idea? Isn't that a tool to foster centralization?

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 3, 2019

yes I am sure. no I don't think so.

we need to be more clever than hide numbers / restrict filtering if we want to foster decentralization. obscuring or hiding information is not a good approach.

the numbers shouldn't be "attached" to a validator by ranking / voting power - but should act like row numbers. so if you sort by anything (or search) you should be able to see the row number.

@faboweb
Copy link
Collaborator

faboweb commented Jun 3, 2019

What would you base the row number on?

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 4, 2019

... the number of the row in the table.

the first row (no matter what filter is active) should display a 1 on the left

like an excel sheet

@faboweb
Copy link
Collaborator

faboweb commented Jun 4, 2019

But the position of a validator could change on two page loads. Did you consider that?

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 4, 2019

But the position of a validator could change on two page loads.

yeah, i think that's fine. it's not a validator number, it's a row number.

for example: how do you answer the following questions?

  • which validator is number 101?
  • which is the 10th most powerful validator?
  • how many validators are there?

@faboweb
Copy link
Collaborator

faboweb commented Jun 4, 2019

which validator is number 101?

I can't because I don't know on which scale I evaluate the rank.

which is the 10th most powerful validator?

I can do that by sorting by voting power and counting down.

how many validators are there?

If this is interesting we should add this is an aggregate value. The value exists in the network tab.

@faboweb
Copy link
Collaborator

faboweb commented Jun 4, 2019

If the row number is just the rank according to voting power, I think that could be fine. It then could be combined with the voting power column.

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 5, 2019

I can't because I don't know on which scale I evaluate the rank.

when sorted by voting power, it will be the one with the number 101

I can do that by sorting by voting power and counting down.

sure, but i'm saying we should help the users out by adding the numbers so you don't have to count

@faboweb
Copy link
Collaborator

faboweb commented Jun 6, 2019

We aligned on making the rank the voting power and adding the rank to the voting power column

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@jbibla
Copy link
Collaborator Author

jbibla commented Aug 26, 2019

this is still relevant. our rows need numbers. @colw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants