Switch from hash to tag #2287
Switch from hash to tag #2287
Conversation
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #2287 +/- ##
========================================
Coverage 96.42% 96.42%
========================================
Files 106 106
Lines 2403 2403
Branches 129 129
========================================
Hits 2317 2317
Misses 66 66
Partials 20 20 |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
tasks/build/Gaia/COMMIT.sh
Outdated
| # explicit hash instead of a tag so we don't have to trust GitHub. | ||
| export COMMIT=4c5038018163fbb51ad882c0505df4958dec2ea8 | ||
| export COMMIT=v0.33.0 |
There was a problem hiding this comment.
can we move this someplace more obvious while we are on it? Like on in config.js?
There was a problem hiding this comment.
- renaming the file from
COMMITtoVERSION
There was a problem hiding this comment.
the problem is that this is used only in bash / CI, I would prefer to have it either sh or just a file with the string I will put in the TAG variable
There was a problem hiding this comment.
kk let's create an issue for that ?
|
@sabau looks like a small change is required before we merge |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
|
e2e breaking |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
|
Fixed it! sorry I stopped working on this in favour of Browserstack, but was just two export missing |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
| # - store_artifacts: | ||
| # path: builds/Gaia/linux_amd64/* | ||
| - store_artifacts: | ||
| path: builds/Gaia/linux_amd64/* |
There was a problem hiding this comment.
the circle ci environment docker we run in is linux I suppose
| - run: | | ||
| if [ ! -d /tmp/gaia ]; then | ||
| cd tasks/build/Gaia | ||
| . ./COMMIT.sh | ||
| TARGET=/tmp/gaia PLATFORM=linux ./build.sh | ||
| TAG=`cat ./VERSION` TARGET=/tmp/gaia PLATFORM=linux ./build.sh |
There was a problem hiding this comment.
It runs on top of alpine so it's the only supported OS
There was a problem hiding this comment.
is that documented somewhere ?
There was a problem hiding this comment.
It's maybe not that straightforward now that you ask.
we are using the official circleci/golang:1.11
that is built on top of golang:1.11.1
that is built on top of alpine:3.8
but the nice idea was to remove all of those and the build too, and simply use
tendermint/gaia:<TAG>
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: