Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/fixed store cache retrieval #2358

Merged
merged 5 commits into from
Mar 26, 2019
Merged

Fabo/fixed store cache retrieval #2358

merged 5 commits into from
Mar 26, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 26, 2019

We were caching the store but didn't retrieve the cache properly

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #2358 into develop will decrease coverage by 0.12%.
The diff coverage is 25%.

@@             Coverage Diff             @@
##           develop    #2358      +/-   ##
===========================================
- Coverage     96.5%   96.38%   -0.13%     
===========================================
  Files          106      106              
  Lines         2376     2380       +4     
  Branches       129      129              
===========================================
+ Hits          2293     2294       +1     
- Misses          63       66       +3     
  Partials        20       20
Impacted Files Coverage Δ
app/src/renderer/vuex/store.js 90.9% <25%> (-9.1%) ⬇️

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #2358 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2358      +/-   ##
===========================================
+ Coverage     96.5%   96.51%   +<.01%     
===========================================
  Files          106      106              
  Lines         2376     2380       +4     
  Branches       129      129              
===========================================
+ Hits          2293     2297       +4     
  Misses          63       63              
  Partials        20       20
Impacted Files Coverage Δ
app/src/renderer/vuex/store.js 100% <100%> (ø) ⬆️

PENDING.md Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit a3a938d into develop Mar 26, 2019
@fedekunze fedekunze deleted the fabo/fix-store-cache branch March 26, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants