Fede+Fabo/Support ledger cosmos app v1.5 and older versions #2382
Conversation
|
this PR needs to be updated to support the newest |
faboweb
changed the title
|
i don't totally understand this PR. what is also, i am getting an |
|
I forgot: You need to install the Ledger firmware 1.5.0 to test the new address feature: https://github.com/cosmos/ledger-cosmos/blob/master/docs/BUILD.md
I will investigate! |
|
Fixed compatibility with version |
I would expect to see a warning that says my version is old and should be upgraded. |
|
The warning is commented out as the version is not yet available on Ledger Live. |
Co-Authored-By: Jordan Bibla <jbibla@gmail.com>
| Signin in with the address | ||
| <span class="address">{{ address }}</span | ||
| >.<br /> | ||
| Please confirm on your Ledger. |
There was a problem hiding this comment.
is there an action associated with this confirm message? if no, it should say "Please confirm that your address is correct" or something like that.
There was a problem hiding this comment.
Yes it is associated with an action on the Ledger. Please test these critical features on your Ledger if they come up.
| } catch ({ message }) { | ||
| switch (message) { | ||
| case `Transaction rejected`: | ||
| this.connectionError = `Account address rejected` |
There was a problem hiding this comment.
why would an address get rejected?
There was a problem hiding this comment.
The address approval is associated with an action, where you can "reject" the address.
src/vuex/modules/ledger.js
Outdated
| await dispatch(`createLedgerAppInstance`) | ||
| const address = await dispatch(`getLedgerAddressAndPubKey`) | ||
| commit(`setLedgerConnection`, true) | ||
| // DEPRECATION enable once 1.5.0 is available on Ledger Live |
There was a problem hiding this comment.
1.5 was released. still in dev mode.
There was a problem hiding this comment.
Ok I enable this warning then.
Co-Authored-By: Jordan Bibla <jbibla@gmail.com>
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: