Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/ removed click outside #2423

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Fabo/ removed click outside #2423

merged 2 commits into from
Apr 5, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Apr 5, 2019

Click outside was sometimes an unexpected behaviour. I.e. when clicking on your address to copy it when the ActionModal was open. Plus there was a bug that closed the actionmodal immediatly.

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb merged commit 8c1211d into develop Apr 5, 2019
@faboweb faboweb deleted the fabo/removed-click-outside branch April 5, 2019 10:57
@faboweb faboweb mentioned this pull request Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze Awaiting requested review from fedekunze

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faboweb