Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/improve git hooks #2424

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Fabo/improve git hooks #2424

merged 4 commits into from
Apr 5, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Apr 5, 2019

Improves the hooks:

  • only lint staged files
  • autoformat on every commit

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@jbibla jbibla merged commit a963acc into develop Apr 5, 2019
@faboweb faboweb mentioned this pull request Apr 6, 2019
Merged
@colw colw deleted the fabo/improve-hooks branch August 7, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbibla jbibla jbibla approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @jbibla