Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/fix rounding issue in small number #2487

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Fabo/fix rounding issue in small number #2487

merged 3 commits into from
Apr 25, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Apr 25, 2019

Closes #ISSUE

Description:

BEFORE:
image

AFTER:
image

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@jbibla
Copy link
Collaborator

jbibla commented Apr 25, 2019

does this address #2486 ?

@jbibla jbibla merged commit 13dae41 into develop Apr 25, 2019
@faboweb faboweb mentioned this pull request Apr 26, 2019
Merged
@faboweb
Copy link
Collaborator Author

faboweb commented Apr 26, 2019

does this address #2486 ?

No but I can get to that today.

@faboweb faboweb mentioned this pull request Apr 28, 2019
Merged
@colw colw deleted the fao/fix-rounding branch August 7, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbibla jbibla jbibla approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @jbibla