Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/added sign in e2e test #2532

Closed
wants to merge 2 commits into from
Closed

Fabo/added sign in e2e test #2532

wants to merge 2 commits into from

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented May 3, 2019

To demo e2e tests

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb
Copy link
Collaborator Author

faboweb commented May 8, 2019

Will close this and merge it into #2550

@faboweb faboweb closed this May 8, 2019
@faboweb faboweb deleted the fabo/sign-in-e2e-test branch May 8, 2019 08:50
This was referenced May 20, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze Awaiting requested review from fedekunze

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faboweb