colw/Add link to buy Ledger Nano S in about page. #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colw
changed the title
colw
force-pushed
the
colw/add-link-to-buy-ledger
branch
from
cccd886
to
4e20d20
Compare
jbibla
reviewed
May 27, 2019
src/components/common/PageAbout.vue
Outdated
| @@ -43,7 +43,12 @@ | |||
| <p> | |||
| To send transactions with Lunie, you'll have to sign them with your | |||
| Ledger Nano S. If you don't have a Ledger Nano S, you can | |||
| <a href="" target="_blank" rel="noopener norefferer">buy one here</a>. | |||
| <a | |||
| href="https://shop.ledger.com/products/ledger-nano-s" | |||
There was a problem hiding this comment.
Suggested change
| href="https://shop.ledger.com/products/ledger-nano-s" | |
| href="https://shop.ledger.com/?r=3dd204ef7508" |
There was a problem hiding this comment.
Should we just refer to the generic 'Ledger' or 'Ledger Nano`? (i.e. S, X or Blue)
There was a problem hiding this comment.
i think we can say "Ledger Nano" for now on - since we support S and X - what do you think?
|
@colw can you add the same link to these session screens? "Don't have a Ledger yet? Get one here."
|
|
Top screen: Do you want it in addition to the ledger app message? |
added 7 commits
May 29, 2019 15:56
Add slot to LiSession to allow for anchor tag.
|
I also removed all references to |
|
I could also remove he |
jbibla
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add link to buy ledger nano S
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: