Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colw/more mapState #2867

Merged
merged 28 commits into from
Aug 7, 2019
Merged

Colw/more mapState #2867

merged 28 commits into from
Aug 7, 2019

Conversation

colw
Copy link
Contributor

@colw colw commented Aug 7, 2019

Description:

This is not as scary as it looks. It removes getters that could simply be used directly from the store, and therefore use mapState rather than mapGetters.

There was an unused test file removed, and two unused components were removed too.

The goal is to reduce clutter, and to easily know the difference between what is stored and what is calculated.

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@colw colw changed the title Colw/more mapstate Colw/more mapState Aug 7, 2019
@colw colw changed the title Colw/more mapState WIP Colw/more mapState Aug 7, 2019
@colw colw changed the title WIP Colw/more mapState Colw/more mapState Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants