colw/Windows Nano Warning #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colw
changed the title
faboweb
reviewed
Aug 27, 2019
tests/unit/specs/components/ActionModal/components/__snapshots__/ActionModal.spec.js.snap
Show resolved
Hide resolved
added 3 commits
August 27, 2019 13:43
jbibla
reviewed
Aug 27, 2019
Co-Authored-By: Jordan Bibla <jbibla@gmail.com>
|
amazing. thank you colin! |
faboweb
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2672
Description:
First pass at windows detection and warning.
Sign in:
ActionModal *visible on each screen
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: