Colw/graphql validators #2926
Merged
Colw/graphql validators #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 29, 2019 19:30
delegations update Page Validators update Page validator update Filters test update table validator update
Codecov Report
@@ Coverage Diff @@
## develop #2926 +/- ##
===========================================
- Coverage 97.32% 97.09% -0.24%
===========================================
Files 126 126
Lines 2247 2240 -7
Branches 396 391 -5
===========================================
- Hits 2187 2175 -12
- Misses 54 59 +5
Partials 6 6
|
Codecov Report
@@ Coverage Diff @@
## develop #2926 +/- ##
===========================================
- Coverage 97.32% 97.22% -0.11%
===========================================
Files 126 126
Lines 2247 2236 -11
Branches 384 391 +7
===========================================
- Hits 2187 2174 -13
- Misses 54 56 +2
Partials 6 6
|
faboweb
reviewed
Aug 30, 2019
added 9 commits
August 30, 2019 17:18
faboweb
reviewed
Sep 2, 2019
src/components/common/TmPage.vue
Outdated
| @@ -77,7 +77,7 @@ export default { | |||
| default: false | |||
| }, | |||
| error: { | |||
| type: Error, | |||
| type: [Error, Boolean], | |||
There was a problem hiding this comment.
We have a rule about not allowing multiple types per property
There was a problem hiding this comment.
Good call. TMPage already treated it like a Boolean, so I've removed the Error type. Other values will be coerced to Boolean.
faboweb
reviewed
Sep 2, 2019
| @@ -503,17 +472,17 @@ span { | |||
| border-radius: 0.25rem; | |||
| } | |||
|
|
|||
| .validator-status.red { | |||
| .validator-status.jailed { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE
Description:
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: