Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/remove S3 upload #2944

Merged
merged 5 commits into from
Sep 4, 2019
Merged

Fabo/remove S3 upload #2944

merged 5 commits into from
Sep 4, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Sep 4, 2019

Description:

As Lunie is now hosted on Netlify we don't need the S3 upload anymore.

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb mentioned this pull request Sep 4, 2019
Closed
colw
colw reviewed Sep 4, 2019
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
colw
colw previously approved these changes Sep 4, 2019
View reviewed changes
@faboweb faboweb merged commit d2f210a into develop Sep 4, 2019
@faboweb faboweb deleted the fabo/remove-upload branch September 4, 2019 14:00
@faboweb faboweb mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw colw approved these changes

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

@thebkr7 thebkr7 Awaiting requested review from thebkr7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @colw