Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts on ORDERED Channels shouldn't work #321

Closed
AdityaSripal opened this issue Nov 4, 2020 · 7 comments · Fixed by #663
Closed

Timeouts on ORDERED Channels shouldn't work #321

AdityaSripal opened this issue Nov 4, 2020 · 7 comments · Fixed by #663
Assignees
Labels
T: Bug-Unconfirmed TYPE: Bug that has been reported but not verified or triaged

Comments

@AdityaSripal
Copy link
Member

Must VerifyNextSequenceRecv instead of packet receipts for ORDERED channels

@colin-axner colin-axner added the T: Bug-Unconfirmed TYPE: Bug that has been reported but not verified or triaged label Apr 14, 2021
@colin-axner
Copy link
Contributor

is this still true?

cc @seantking

@jackzampolin
Copy link
Member

Is this still true @colin-axner @seantking @AdityaSripal ?

@AdityaSripal
Copy link
Member Author

Looks like it: https://github.com/cosmos/relayer/blob/master/relayer/relayPackets.go#L41

It should be querying next sequence recv in case of ordered channel

@jtieri
Copy link
Member

jtieri commented Jan 12, 2022

Is this still applicable? With the recent refactors to the relayer to move everything behind the provider interface this could would now exists in lens

@colin-axner
Copy link
Contributor

I'm guessing so, as @AdityaSripal says:

Must VerifyNextSequenceRecv instead of packet receipts for ORDERED channels

Timeouts on order channels require proofs of NextSequenceRecv
Timeouts on unordered channels require non existence proofs of packet receipt.

The function linked above works for unordered channels. You need different functionality for ordered channels

@colin-axner
Copy link
Contributor

You can probably test with interchain accounts once beta1 is out. Beta1 will allow interchain accounts to have a timeout value specified by the user (currently set to a constant that is never reached). Interchain accounts uses ordered channels

@AdityaSripal
Copy link
Member Author

Seems like the msgRelayTimeout still only queries packet receipt. Instead it should be querying packet receipts for UNORDERED channels, and NextSequenceRecv for ORDERED channels.

https://github.com/strangelove-ventures/lens/blob/dc50c1d0d3b61614f09d125d8ae931f306625057/client/relayer_packets.go#L44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Bug-Unconfirmed TYPE: Bug that has been reported but not verified or triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants