Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display proposals index #1401

Closed
4 of 5 tasks
faboweb opened this issue Oct 2, 2018 · 4 comments · Fixed by #1488
Closed
4 of 5 tasks

Display proposals index #1401

faboweb opened this issue Oct 2, 2018 · 4 comments · Fixed by #1488

Comments

@faboweb
Copy link
Collaborator

faboweb commented Oct 2, 2018

Scope:

  • create proposal overview related getter functions in lcdClient
  • create a governance module
  • display proposals
  • write tests for module
  • write tests for lcdClient
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 8, 2018

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 8, 2018

Is it the case that gaia-8001 doesn't include proposals? If so, how will we test this—with a local node in which we create proposals via the CLI? I'm unable to create a proposal via the CLI and asked for help in #dev-cosmos-sdk.

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 9, 2018

The OpenAPI spec doesn't include governance yet.

The spec doesn't even contain staking yet. Still some miles to go.

how will we test this—with a local node

Yes. This should work as there are tests for it here: https://github.com/cosmos/cosmos-sdk/blob/develop/cmd/gaia/cli_test/cli_test.go#L318

@fedekunze
Copy link
Contributor

Some work was done in on the following commit: 516ab54

Note: The changes are the deletions on that commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants