Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t increase amount to undelegate (add the number) when 0 < bond < 1
 #1409

Closed
faboweb opened this issue Oct 4, 2018 · 8 comments · Fixed by #1498
Closed

Can’t increase amount to undelegate (add the number) when 0 < bond < 1
 #1409

faboweb opened this issue Oct 4, 2018 · 8 comments · Fixed by #1498
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Oct 4, 2018

Follow up of #1367 (review)

@faboweb faboweb added bug 🐛 issues related to unhandled errors in the code that need to be fixed staking1 labels Oct 4, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 8, 2018

I tried to replicate this by bonding 0.5 Steak but Voyager wouldn't let me (Confirm Delegation is disabled):

screen shot 2018-10-08 at 3 47 01 pm

Is this expected behavior?

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 9, 2018

Currently it is. Delegation transactions only allow for whole numbers to be delegated.

@jbibla
Copy link
Collaborator

jbibla commented Oct 9, 2018

Delegation transactions only allow for whole numbers to be delegated.

what is the reason?

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 10, 2018

what is the reason?

apparently this is due to the fact, that there will be no fractions of atoms. we will only have sub-atoms (1:1000000000) and users will loose fractions of sub-atoms in certain scenarios. we then delegate sub-atoms.

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 10, 2018

@fedekunze could you quickly help with clarify what the original issue was you filed?

@fedekunze
Copy link
Contributor

It’s more like because the input field only increases the step by 1 using the up button, if you have < 1 atom due to slashing you won’t be able to do anything, only typing the exact amount you want to undelegate.

The ideal situation is that the inputs field increases the step by 1 (step=1) until you reach floor(maximum) and then change the step to decimal in order to be able to unbond your ‘maximum’ specified amount

@NodeGuy NodeGuy assigned jbibla and unassigned faboweb Oct 23, 2018
@fedekunze
Copy link
Contributor

@faboweb @NodeGuy Do we want to be able to delegate, redelegate and unbond subatoms ?

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 30, 2018

yes the user should be able to delegate, redelegate and unbond subatoms. the concern before was that delegating fractional tokens (subatoms) is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants