add specs for update method and value watcher #1776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1776 +/- ##
===========================================
+ Coverage 97.72% 97.85% +0.12%
===========================================
Files 103 102 -1
Lines 2110 2096 -14
Branches 92 93 +1
===========================================
- Hits 2062 2051 -11
+ Misses 39 37 -2
+ Partials 9 8 -1
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #1776 +/- ##
===========================================
+ Coverage 97.72% 97.85% +0.12%
===========================================
Files 103 102 -1
Lines 2110 2096 -14
Branches 92 93 +1
===========================================
- Hits 2062 2051 -11
+ Misses 39 37 -2
+ Partials 9 8 -1
|
Codecov Report
@@ Coverage Diff @@
## develop #1776 +/- ##
===========================================
+ Coverage 97.72% 97.85% +0.12%
===========================================
Files 103 102 -1
Lines 2110 2096 -14
Branches 92 93 +1
===========================================
- Hits 2062 2051 -11
+ Misses 39 37 -2
+ Partials 9 8 -1
|
Codecov Report
@@ Coverage Diff @@
## develop #1776 +/- ##
==========================================
Coverage ? 97.85%
==========================================
Files ? 102
Lines ? 2096
Branches ? 93
==========================================
Hits ? 2051
Misses ? 37
Partials ? 8 |
faboweb
reviewed
Dec 28, 2018
| @@ -1,6 +1,8 @@ | |||
| import { mount } from "@vue/test-utils" | |||
| import htmlBeautify from "html-beautify" | |||
| import TmFieldSeed from "common/TmFieldSeed" | |||
| import autosize from "autosize" | |||
| const spy = jest.spyOn(autosize, `update`) | |||
There was a problem hiding this comment.
This should probably go into a beforeEach to prevent side effects from others tests.
There was a problem hiding this comment.
Or just into the according test.
|
Ping @coreycosman |
|
i messaged him - he may be travelling / on vacation. |
fedekunze
changed the title
faboweb
previously approved these changes
Jan 8, 2019
…te-to-100%-coverage
faboweb
changed the title
|
unit tests failing |
|
do you have any idea why e2e test # 42 - line 198 of test/e2e/signin.js would have broken because of the unit tests I wrote? I do not quite understand how my tests are affecting the e2e tests, or how to correct this error. Any help is greatly appreciated. |
|
E2E tests are sometimes unreliable because of async problems. If your unit tests run fine, I will make the PR pass. |
|
Yea all tests are running fine
…On Wed, Jan 16, 2019 at 4:47 PM Fabian ***@***.***> wrote:
E2E tests are sometimes unreliable because of async problems. If your unit
tests run fine, I will make the PR pass.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1776 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ad4GWLnq7m5WwTVJ0BIJXr6JyqzLY5eXks5vDx9bgaJpZM4Zf-0X>
.
|
|
Unit tests are broken: |
|
please see my most recent PR |
|
I will close this then, let's use the other PR |
This was referenced Jan 16, 2019
This was referenced Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1774
Description:
added specs for update method and value watcher- test coverage to 100% for this file.
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer