Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message on signing options #1918

Closed
fedekunze opened this issue Jan 31, 2019 · 8 comments · Fixed by #1916
Closed

Add message on signing options #1918

fedekunze opened this issue Jan 31, 2019 · 8 comments · Fixed by #1916
Assignees
@fedekunze

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Jan 31, 2019 •
edited
Loading

i think (the action modals) should open but display a message that says you need to sign in to use them.

Originally posted by @jbibla in #1814
@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

So the thinking here is that the modal is opening but stating that the user needs to sign in first?

@fedekunze
Copy link
Contributor Author

I honestly don't think this issue is necessary, we already give the user the option to log in with the desired method to sign, which makes things pretty clear

@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

Yes we do. This is why I was asking if the issue means showing a "First Sign In" on ActionModals if the user is not signed in. Is that correct or does it mean sth. else?

@jbibla
Copy link
Collaborator

jbibla commented Feb 11, 2019

lol @fedekunze you quoted me and got it wrong #fakenews

screen shot 2019-02-11 at 8 54 45 am

  1. action modals should always open for users (whether they are signed in or not)
  2. if the user is not signed in, the action modal should prompt the user to sign in

@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

#fakenews

@faboweb faboweb mentioned this issue Feb 11, 2019
Merged
2 tasks
@fedekunze
Copy link
Contributor Author

2. if the user is not signed in, the action modal should prompt the user to sign in

you mean change the action modal's body for a message to sign in ? @jbibla

@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

yes

fedekunze pushed a commit that referenced this issue Feb 11, 2019
add message to log on action modal; closes #1918
caf18c3
@fedekunze fedekunze self-assigned this Feb 11, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 11, 2019

yep! like "Hey! CooL! You want to DeLeGaTe? Sign up here!"

jbibla pushed a commit that referenced this issue Feb 13, 2019
@fedekunze @jbibla
fedekunze/1718 remove session pt 1 (#1916)
febe91a 
* session signedIn restrictions

* update tests

* fix tests

* changelog and linter

* coverage

* more tests for coverage

* snaps

* more tests

* update staking page tests

* revert redirect and add preferences to required auth views

* add message to log on action modal; closes #1918

* update snaps

* changelog 2

* address comments from code review

* lint

* update delegation tests

* delete route guard condition

* update snap action modal
This was referenced Feb 14, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fedekunze/1718 remove session pt 1 luniehq/lunie
3 participants
@faboweb @jbibla @fedekunze