Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

David/split refactors from 1522 #1567

Merged
merged 19 commits into from
Nov 14, 2018
Merged

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Nov 13, 2018

Description:

Split from #1522

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #1567 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1567      +/-   ##
===========================================
- Coverage    96.62%   96.61%   -0.01%     
===========================================
  Files          100      100              
  Lines         1953     1950       -3     
  Branches        95       95              
===========================================
- Hits          1887     1884       -3     
  Misses          56       56              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/connectors/lcdClient.js 97.43% <100%> (-0.13%) ⬇️
app/src/renderer/connectors/node.js 100% <100%> (ø) ⬆️
app/src/renderer/main.js 92.68% <100%> (ø) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
@faboweb faboweb merged commit b64f922 into develop Nov 14, 2018
@faboweb faboweb deleted the fedekunze/split-refactors-from-1522 branch November 14, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants