Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1749-tally #1765

Merged
merged 17 commits into from
Dec 20, 2018
Merged

fedekunze/1749-tally #1765

merged 17 commits into from
Dec 20, 2018

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Dec 19, 2018

Closes #1749

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1765 into develop will decrease coverage by 0.04%.
The diff coverage is 96.42%.

@@             Coverage Diff             @@
##           develop    #1765      +/-   ##
===========================================
- Coverage    97.72%   97.67%   -0.05%     
===========================================
  Files          103      103              
  Lines         2106     2110       +4     
  Branches        93       92       -1     
===========================================
+ Hits          2058     2061       +3     
- Misses          39       40       +1     
  Partials         9        9
Impacted Files Coverage Δ
.../renderer/components/governance/TableProposals.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/store.js 100% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClientMock.js 99.19% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 100% <ø> (ø) ⬆️
...rc/renderer/components/governance/PageProposal.vue 100% <100%> (ø) ⬆️
.../src/renderer/components/governance/LiProposal.vue 100% <100%> (ø) ⬆️
...p/src/renderer/vuex/modules/governance/deposits.js 100% <100%> (ø) ⬆️
.../src/renderer/vuex/modules/governance/proposals.js 96.15% <83.33%> (-3.85%) ⬇️

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1765 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1765      +/-   ##
===========================================
+ Coverage    97.72%   97.72%   +<.01%     
===========================================
  Files          103      103              
  Lines         2106     2110       +4     
  Branches        93       92       -1     
===========================================
+ Hits          2058     2062       +4     
  Misses          39       39              
  Partials         9        9
Impacted Files Coverage Δ
.../renderer/components/governance/TableProposals.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/store.js 100% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClientMock.js 99.19% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 100% <ø> (ø) ⬆️
...rc/renderer/components/governance/PageProposal.vue 100% <100%> (ø) ⬆️
.../src/renderer/components/governance/LiProposal.vue 100% <100%> (ø) ⬆️
...p/src/renderer/vuex/modules/governance/deposits.js 100% <100%> (ø) ⬆️
.../src/renderer/vuex/modules/governance/proposals.js 100% <100%> (ø) ⬆️

@fedekunze fedekunze changed the title WIP: fedekunze/1749-tally fedekunze/1749-tally Dec 20, 2018
faboweb
faboweb previously approved these changes Dec 20, 2018
Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice!

@faboweb
Copy link
Collaborator

faboweb commented Dec 20, 2018

but missing a little coverage ;)

@faboweb faboweb merged commit 0808085 into develop Dec 20, 2018
@faboweb faboweb deleted the fedekunze/1749-tally branch December 20, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use tally endpoint to query active proposals tally
2 participants