fedekunze/remove demo mode #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2019 17:21
Codecov Report
@@ Coverage Diff @@
## develop #1792 +/- ##
===========================================
- Coverage 95.07% 95.05% -0.02%
===========================================
Files 122 122
Lines 2982 2953 -29
Branches 128 122 -6
===========================================
- Hits 2835 2807 -28
Misses 137 137
+ Partials 10 9 -1
|
added 3 commits
January 3, 2019 19:05
…k changes" This reverts commit ce34c16. Removing this file breaks e2e tests
sabau
reviewed
Jan 4, 2019
sabau
reviewed
Jan 4, 2019
| }) | ||
|
|
||
| it(`has the expected html structure`, () => { | ||
| expect(wrapper.vm.$el).toMatchSnapshot() | ||
| console.log(wrapper.vm.$el.outerHTML) |
sabau
previously requested changes
Jan 4, 2019
sabau
approved these changes
Jan 4, 2019
| @@ -87,7 +77,7 @@ describe(`TmConnectedNetwork`, () => { | |||
| }) | |||
|
|
|||
| it(`shows the connected node`, async () => { | |||
| instance = mount(TmConnectedNetwork) | |||
| let instance = mount(TmConnectedNetwork) | |||
There was a problem hiding this comment.
Ah sorry I wasn't explicit, I meant all the instance of let instance
This was referenced Jan 16, 2019
This was referenced Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses second checkbox from #1742
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer