Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network page: display bech32 addr of the block proposer #1946

Closed
fedekunze opened this issue Feb 11, 2019 · 7 comments
Closed

Network page: display bech32 addr of the block proposer #1946

fedekunze opened this issue Feb 11, 2019 · 7 comments
Assignees
@jbibla
Labels
high priority ❗ ux-improvement issues that would improve the user experience

Comments

@fedekunze
Copy link
Contributor

Description:

eg Proposer: 92189378250AFCE52A3CF06A0E1DEBA998BEC97E should be displayed as bech32
@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

Sharing: I thought this should be handled by Tendermint, but Tendermint is not bound to Cosmos so it will probably not use bech32 for their addresses.

@faboweb faboweb added ux-improvement issues that would improve the user experience explorer 🌔 high priority ❗ labels Feb 11, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 11, 2019

agreed! i opened this issue about it:

cosmos/cosmos-sdk#3544

@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

Ah this comes from the SDK then your issue is valid!

@fedekunze
Copy link
Contributor Author

Can't we just decode it client-side meanwhile ?

@faboweb
Copy link
Collaborator

faboweb commented Feb 11, 2019

yes we should anyway until this is fixed in the SDK.

@jbibla
Copy link
Collaborator

jbibla commented Feb 11, 2019

works for me!

@jbibla
Copy link
Collaborator

jbibla commented Feb 12, 2019

make this a link to the validator page

@jbibla jbibla self-assigned this Feb 12, 2019
@faboweb faboweb mentioned this issue Feb 14, 2019
Closed
@jbibla jbibla mentioned this issue Feb 14, 2019
Merged
5 tasks
@jbibla jbibla closed this as completed Feb 14, 2019
@faboweb faboweb mentioned this issue Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
high priority ❗ ux-improvement issues that would improve the user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faboweb @jbibla @fedekunze