Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ec2 scripts with new cli commands versions #2002

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Feb 18, 2019

Signed-off-by: Karoly Albert Szabo szabo.karoly.a@gmail.com

Description:

  • fix min amount of stakes
  • fix --moniker
  • fix tx send
  • fix wiring into AWS from https to http (not in GIT until we don't switch to SRE nodes)

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@sabau sabau marked this pull request as ready for review February 18, 2019 16:58
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #2002 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2002   +/-   ##
========================================
  Coverage    94.89%   94.89%           
========================================
  Files          121      121           
  Lines         2627     2627           
  Branches       123      123           
========================================
  Hits          2493     2493           
  Misses         125      125           
  Partials         9        9

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #2002 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2002      +/-   ##
===========================================
+ Coverage    94.89%   94.93%   +0.03%     
===========================================
  Files          121      121              
  Lines         2627     2627              
  Branches       123      123              
===========================================
+ Hits          2493     2494       +1     
+ Misses         125      124       -1     
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/connectors/api.js
app/src/renderer/connectors/lcdClient.js 100% <0%> (ø)
app/src/renderer/connectors/lcdClientMock.js 96.46% <0%> (+0.29%) ⬆️

Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can't test though :)

@sabau
Copy link
Contributor Author

sabau commented Feb 18, 2019

Thanks! yeah it was an explorative pattern :) i pushed the scripts that worked on our EC2 instances.

@sabau sabau merged commit 1c2112a into develop Feb 18, 2019
@sabau sabau deleted the sabau/align-ec2-scripts branch February 18, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants