Faucet don't give a second chance #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #2210 +/- ##
==========================================
- Coverage 95.42% 95.4% -0.02%
==========================================
Files 109 109
Lines 2295 2287 -8
Branches 116 114 -2
==========================================
- Hits 2190 2182 -8
Misses 92 92
Partials 13 13
|
jbibla
reviewed
Mar 7, 2019
.aws/faucet.sh
Outdated
| ACCOUNT_INFO=$(./gaiacli query account ${DESTINATION} --chain-id ${NETWORK} --trust-node --home .) | ||
| dt=$(date '+%d/%m/%Y %H:%M:%S'); | ||
| if [[ ${ACCOUNT_INFO} == *"auth/Account"* ]]; then | ||
| echo "$dt - $DESTINATION already funded, bye greedy b****rd!" |
There was a problem hiding this comment.
lol i don't know about this b****rd
jbibla
reviewed
Mar 7, 2019
| @@ -15,7 +15,7 @@ NODEID=$(./gaiad tendermint show-node-id --home .) | |||
|
|
|||
| # Create our main account and add it to the genesis with a lot of money | |||
| echo ${PASSWORD} | ./gaiacli keys add ${ACCOUNT} --home . > account_address.log | |||
| ./gaiad add-genesis-account $(./gaiacli keys show ${ACCOUNT} --home . --address) 100000000000000000stake,999000000000photino,123123123123cococoin --home . | |||
| ./gaiad add-genesis-account $(./gaiacli keys show ${ACCOUNT} --home . --address) 1000000000000000000000stake,100000000000000000000photino,123123123123123123cococoin --home . | |||
There was a problem hiding this comment.
why not 9999999999999999999999999999999 so we don't run out
There was a problem hiding this comment.
18446744073709551615 should be the biggest available
There was a problem hiding this comment.
lol ok why not that number then?
There was a problem hiding this comment.
we are already overflowing XD:
1000000000000000000000
18446744073709551615
So probably we already have everything we can
There was a problem hiding this comment.
My bad, on SDK I found out big integers are used so we have way more than 64 bits, as soon as I'm sure about the number of bits I'll update this number
fedekunze
reviewed
Mar 7, 2019
.aws/faucet.sh
Outdated
| AMOUNTP=5photino | ||
| AMOUNTC=1cococoin | ||
| AMOUNTP=5000000photino | ||
| AMOUNTC=123123cococoin |
There was a problem hiding this comment.
next coin will be that one
…ommands Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
faboweb
reviewed
Mar 11, 2019
faboweb
reviewed
Mar 11, 2019
| ADDRESS=$(./gaiacli keys show ${ACCOUNT} --home . --address) | ||
| echo "stakes $AMOUNTS at $DESTINATION" | ||
| echo ${PASSWORD} | ./gaiacli tx send ${DESTINATION} ${AMOUNTS} --home . --from ${ADDRESS} --chain-id=${NETWORK} | ||
| sleep 5s # TODO: should be smarter, check if block was created or not |
There was a problem hiding this comment.
smaller timeout doesn't work? @alessio this was the problem I explained
There was a problem hiding this comment.
yeah in this moment apparently that's the safest solution available
Co-Authored-By: sabau <szabo.karoly.a@gmail.com>
faboweb
previously approved these changes
Mar 11, 2019
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #2210 +/- ##
========================================
Coverage 95.43% 95.43%
========================================
Files 109 109
Lines 2300 2300
Branches 116 116
========================================
Hits 2195 2195
Misses 92 92
Partials 13 13 |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
faboweb
approved these changes
Mar 12, 2019
jbibla
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
print date to have decent logs
Thank you! 🚀
For contributor:
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: