Fabo/0.33.0 #2225
Merged
Fabo/0.33.0 #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: faboweb <frznhope@gmail.com>
…tion-format' into fabo/0.33.0
added 2 commits
March 9, 2019 16:46
Codecov Report
@@ Coverage Diff @@
## develop #2225 +/- ##
===========================================
- Coverage 95.39% 94.66% -0.73%
===========================================
Files 109 109
Lines 2279 2288 +9
Branches 114 116 +2
===========================================
- Hits 2174 2166 -8
- Misses 92 109 +17
Partials 13 13
|
Codecov Report
@@ Coverage Diff @@
## develop #2225 +/- ##
===========================================
+ Coverage 95.4% 95.42% +0.01%
===========================================
Files 109 109
Lines 2287 2295 +8
Branches 114 116 +2
===========================================
+ Hits 2182 2190 +8
Misses 92 92
Partials 13 13
|
5 tasks
|
It's not. Merge conflict. I removed the file again.
Federico Kunze <notifications@github.com> schrieb am Sa., 9. März 2019,
19:31:
… ***@***.**** commented on this pull request.
------------------------------
In app/src/renderer/components/transactions/TmLiAnyTransaction.vue
<#2225 (comment)>:
> @@ -0,0 +1,100 @@
+<template>
We renamed this file to LiAnyTransaction. Why is this being changed ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2225 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmO2U3DIPobRYRtOKy4c9NaAhMl1sr4ks5vU_4AgaJpZM4bmvpg>
.
|
jbibla
reviewed
Mar 9, 2019
| @@ -159,11 +156,11 @@ export default ({ node }) => { | |||
|
|
|||
| await dispatch(`sendTx`, { | |||
| type: `postDelegation`, | |||
| to: wallet.address, // TODO strange syntax | |||
| to: session.address, // TODO strange syntax | |||
There was a problem hiding this comment.
yep, just changed the source of the address
There was a problem hiding this comment.
what's the strange syntax? can we create an issue ?
There was a problem hiding this comment.
there is already an issue around refactoring the send module #1828
jbibla
reviewed
Mar 9, 2019
| @@ -36,7 +36,7 @@ | |||
| "prepush": "bash ./tasks/changelog-changed-check.sh && yarn lint", | |||
| "postcheckout": "yarn", | |||
| "watch": "tasks/watch.sh", | |||
| "nodes": "node ./tasks/testnet.js", | |||
| "nodes": "node ./tasks/local-testnet/start.js", | |||
|
hmm I still get the error from undelegations: |
fedekunze
suggested changes
Mar 11, 2019
|
@fedekunze could you re-eval please? |
This is still failing: (re)delegation, unbonding, proposals, send, etc |
will fix this |
added 3 commits
March 11, 2019 19:10
sabau
approved these changes
Mar 11, 2019
|
Need to check version again. The commit stated 0.32.0. Maybe need to upgrade again. |
|
Karoly was this manually tested ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2103
Updates to SDK 0.33.0
Improves on local testnet generation and usage. Always sends tokens to a fixed address: "cosmos1ek9cd8ewgxg9w5xllq9um0uf4aaxaruvcw4v9e"
Needs the backend to be updated
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: