Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint basic rules #2236

Merged
merged 5 commits into from
Mar 12, 2019
Merged

Add eslint basic rules #2236

merged 5 commits into from
Mar 12, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Mar 11, 2019

Description:

  • brace-style
  • no-tabs
  • max-len
  • no-trailing-spaces

Thank you! 🚀

For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@sabau
eslint:
7662fc2 
- brace-style
- no-tabs
- max-len
- no-trailing-spaces

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #2236 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2236      +/-   ##
===========================================
+ Coverage    95.42%   95.43%   +<.01%     
===========================================
  Files          109      109              
  Lines         2295     2300       +5     
  Branches       116      116              
===========================================
+ Hits          2190     2195       +5     
  Misses          92       92              
  Partials        13       13
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/send.js 100% <ø> (ø) ⬆️
...erer/components/transactions/LiBankTransaction.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmFormGroup.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ActionModal.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 100% <ø> (ø) ⬆️
.../renderer/components/common/TmConnectedNetwork.vue 100% <ø> (ø) ⬆️
...derer/components/transactions/LiGovTransaction.vue 100% <ø> (ø) ⬆️
...ponents/transactions/LiDistributionTransaction.vue 85.71% <ø> (ø) ⬆️
app/src/renderer/components/common/TmListItem.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/staking/LiValidator.vue 90% <ø> (ø) ⬆️
... and 18 more

jbibla
jbibla reviewed Mar 11, 2019
View reviewed changes
.eslintrc.js
"brace-style": ["error", "1tbs"],
"semi": ["error", "never"],
"no-tabs": ["error"],
"max-len": ["error", { "code": 80, "ignoreStrings": true, "ignoreComments": true, "ignoreTemplateLiterals": true }],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i miss prettier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, basically prettier is enforcing a set of preconfigured rules, I'm picking the easy ones piece by piece, but some take time where those are quick to add

@sabau
apply to merge
66b57f1 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
faboweb
faboweb previously approved these changes Mar 12, 2019
View reviewed changes
fedekunze
fedekunze approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit 2112e68 into develop Mar 12, 2019
@fedekunze fedekunze deleted the sabau/no-tabs branch March 12, 2019 16:28
@faboweb faboweb mentioned this pull request Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jbibla jbibla jbibla approved these changes

@faboweb faboweb faboweb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sabau @faboweb @jbibla @fedekunze