fix: ensure pageviews are fetched after DOM is loaded #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
approved these changes
Nov 30, 2024
1 task
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
## [7.2.1](v7.2.0...v7.2.1) (2024-12-05) ### Bug Fixes * **build:** exclude `purgecss.js` from output files ([#2090](#2090)) ([976e1a1](976e1a1)) * correct the import condition for theme script ([#2075](#2075)) ([a16aa7d](a16aa7d)) * ensure pageviews are fetched after DOM is loaded ([#2071](#2071)) ([b4019f3](b4019f3)) * **toc:** resume fade up animation in desktop mode ([#2085](#2085)) ([8280adb](8280adb))
|
🎉 This PR is included in version 7.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The pageviews script is loaded inside the
<head>and is therefore executed too early, causing pageviews to display an infinite spinner. In Chirpy 7.1.1 the script was loaded at the end of the<body>.