Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust font sizes of headings according to square roots to make them look better #983

Closed
wants to merge 1 commit into from

Conversation

v4vong
Copy link
Contributor

@v4vong v4vong commented Apr 13, 2023

Description

Adjust font sizes of headings according to this algorithm:

H1 = 2/sqrt1 = 2
H2 = 2/sqrt2 = 1.414
H3 = 2/sqrt3 = 1.155
H4 = 2/sqrt4 = 1
H5 = 2/sqrt5 = 0.894
H6 = 2/sqrt6 = 0.816

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version:
  • Operating system:
  • Ruby version:
  • Bundler version:
  • Jekyll version:

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, as this PR involves layout design (beyond the scope of the contribution guidelines), may I ask if there is any theoretical support for this algorithm? If so, please let me know.

@v4vong
Copy link
Contributor Author

v4vong commented Apr 14, 2023

Hi there, as this PR involves layout design (beyond the scope of the contribution guidelines), may I ask if there is any theoretical support for this algorithm? If so, please let me know.

No theoretical support. I just think the size of h3, h4, and h5 is too close according to current settings, it's hard to tell them apart by the naked eye. Then I want to use a specific rule to calculate the font size of headings, so as to avoid randomness. Of course, it does not have to use sqrt.

@cotes2020
Copy link
Owner

So I'm sorry, this modification will not be merged, but I will come up with a new way to make the size differences between headings more apparent.

@v4vong
Copy link
Contributor Author

v4vong commented Apr 15, 2023

So I'm sorry, this modification will not be merged, but I will come up with a new way to make the size differences between headings more apparent.

Cool. Looking forward to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants