Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split docker entrypoint and command #192

Merged
merged 3 commits into from
Apr 9, 2021
Merged

split docker entrypoint and command #192

merged 3 commits into from
Apr 9, 2021

Conversation

filex
Copy link
Contributor

@filex filex commented Apr 9, 2021

to make it easier to give parameters:

$ docker run avenga/couper version
$ docker run avenga/couper run -p 1234

docker: split entrypoint and command
406bba9 
to make it easier to give parameters:

$ docker run avenga/couper version
$ docker run avenga/couper run -p 1234
@filex filex requested a review from malud April 9, 2021 06:43
malud
malud requested changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug_report.md should be updated too :)

@filex filex requested a review from malud April 9, 2021 07:07
@malud malud merged commit 7529fee into master Apr 9, 2021
@malud malud deleted the docker-cmd branch April 9, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filex @malud @alex-schneider