Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jwt token value #345

Merged
merged 8 commits into from
Oct 19, 2021
Merged

Jwt token value #345

merged 8 commits into from
Oct 19, 2021

Conversation

afflerbach
Copy link
Contributor

@afflerbach afflerbach commented Oct 14, 2021 •
edited
Loading

Added token_value attribute to jwt block

Examples:

token_value = "…token…"
token_value = request.json_body.mytoken
token_value = request.form_body.mytoken[0]
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@afflerbach afflerbach force-pushed the jwt-token-value branch 2 times, most recently from b1cd1c9 to 405c8b9 Compare October 15, 2021 06:38
@afflerbach afflerbach marked this pull request as draft October 15, 2021 06:46
@afflerbach afflerbach marked this pull request as ready for review October 15, 2021 07:02
malud
malud requested changes Oct 18, 2021
View reviewed changes
accesscontrol/jwt.go Outdated Show resolved Hide resolved
@afflerbach afflerbach marked this pull request as draft October 18, 2021 15:08
johakoch
johakoch requested changes Oct 19, 2021
View reviewed changes
config/ac_jwt.go Show resolved Hide resolved
accesscontrol/jwt_test.go Outdated Show resolved Hide resolved
accesscontrol/jwt_test.go Outdated Show resolved Hide resolved
accesscontrol/jwt_test.go Outdated Show resolved Hide resolved
accesscontrol/jwt_test.go Outdated Show resolved Hide resolved
accesscontrol/jwt_test.go Outdated Show resolved Hide resolved
docs/REFERENCE.md Outdated Show resolved Hide resolved
johakoch
johakoch reviewed Oct 19, 2021
View reviewed changes
docs/REFERENCE.md Outdated Show resolved Hide resolved
johakoch
johakoch reviewed Oct 19, 2021
View reviewed changes
docs/REFERENCE.md Outdated Show resolved Hide resolved
@afflerbach afflerbach marked this pull request as ready for review October 19, 2021 07:56
@johakoch johakoch merged commit 2c5661d into master Oct 19, 2021
@johakoch johakoch deleted the jwt-token-value branch October 19, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch requested changes

@malud malud malud requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afflerbach @malud @johakoch