Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post run action takes too much time occasionally #580

Closed
davidak09 opened this issue Mar 5, 2024 · 2 comments · Fixed by #598
Closed

Post run action takes too much time occasionally #580

davidak09 opened this issue Mar 5, 2024 · 2 comments · Fixed by #598

Comments

@davidak09
Copy link

Some runs of post run action for coursier/cache-action@v6 take minutes to finish. The behavior is flipping, other runs are done under one second. We're using proprietary runners.

Screenshot 2024-03-05 at 16 51 37

Could you please guess what might be the cause of this slow step?

@laughedelic
Copy link
Member

I have been observing this for a while as well. If you flip the timestamps in the logs, you can see that it gets stuck after saving all the cache for ~3m:
Screenshot 2024-03-20 at 17 35 25

What could be the reason for this?

@laughedelic
Copy link
Member

laughedelic commented Mar 26, 2024

I noticed this in the actions/cache: https://github.com/actions/cache/blob/0c45773b623bea8c8e75f6c82b208c3cf94ea4f9/src/saveImpl.ts#L116-L123

    // node will stay alive if any promises are not resolved,
    // which is a possibility if HTTP requests are dangling
    // due to retries or timeouts. We know that if we got here
    // that all promises that we care about have successfully
    // resolved, so simply exit with success.
    if (earlyExit) {
        process.exit(0);
    }

Maybe it can help here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants