Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all mutations in definition files? #8

Open
rambaut opened this issue Jun 4, 2021 · 1 comment
Open

Include all mutations in definition files? #8

rambaut opened this issue Jun 4, 2021 · 1 comment

Comments

@rambaut
Copy link
Contributor

rambaut commented Jun 4, 2021

At the moment it is inconsistent whether the definition files contain all mutations from reference or just the ones on the stem branch. I.e., P323L, D614G etc. For simplicity and consistency, it may be good to include all of them. But the required number of 'alts' would need to be revised up.

@rmcolq
Copy link
Contributor

rmcolq commented Jul 12, 2021

We can make it more clear by putting some of them in a list in the JSON with key "ancestral" - this is what scorpio define already does when creating a new JSON file for a constellation if an outgroup is specified. The result would be that classify would use all the sites when classifying (so the rules should reflect that), but haplotype would only include the new sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants