Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MLX): deprecated UserActionHistory class #891

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat(MLX): deprecated UserActionHistory class #891

merged 1 commit into from
Dec 19, 2024

Conversation

paulgerold
Copy link
Contributor

@paulgerold paulgerold commented Dec 3, 2024 •
edited
Loading

The user action history is not used anymore in admin-ui, so it is marked as deprecated

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@paulgerold paulgerold marked this pull request as ready for review December 3, 2024 15:13
@paulgerold paulgerold requested review from a team as code owners December 3, 2024 15:13
@paulgerold paulgerold force-pushed the MLX-1549-remove-user-action-history-config branch from 1bdf041 to 9065288 Compare December 19, 2024 16:06
@paulgerold paulgerold enabled auto-merge December 19, 2024 16:18
@paulgerold paulgerold added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit 8d7e4b6 Dec 19, 2024
5 checks passed
@paulgerold paulgerold deleted the MLX-1549-remove-user-action-history-config branch December 19, 2024 16:21
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 57.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTangCoveo JTangCoveo JTangCoveo approved these changes

@lprovost-coveo lprovost-coveo lprovost-coveo approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@gdostie gdostie Awaiting requested review from gdostie gdostie is a code owner automatically assigned from coveo/frontend-foundation

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgerold @GermainBergeron @lprovost-coveo @JTangCoveo