Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modeldetailspreparationdetails): match ML Requirements #904

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Jan 9, 2025

Acceptance Criteria

After introduction it was discovered that this property has a typo. It is gramatically incorrect but the current value is indeed facetsDetails and not facetDetails.

The property has a high cost and impact to rename so the Service team won't rename it anytime soon. To make things work we need to match their property name.

https://github.com/coveo-platform/ml-config-service/pull/2456

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 0bfe261 Jan 9, 2025
11 checks passed
@lprovost-coveo lprovost-coveo deleted the feat/MLX-1849-typo branch January 9, 2025 20:54
Copy link

github-actions bot commented Jan 9, 2025

🎉 This PR is included in version 57.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants